If a run has been claimed, move work order from "pending" to "running"#4637
Merged
midigofrank merged 5 commits intomainfrom Apr 20, 2026
Merged
If a run has been claimed, move work order from "pending" to "running"#4637midigofrank merged 5 commits intomainfrom
midigofrank merged 5 commits intomainfrom
Conversation
This is likely to be super contentious, but the reality is that once it's claimed, we CANNOT STOP IT or get it back. It can no longer be "cancelled". From the perspective of Lightning it's running, and we can't stop it.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4637 +/- ##
==========================================
- Coverage 89.63% 89.60% -0.04%
==========================================
Files 444 444
Lines 21558 21558
==========================================
- Hits 19324 19317 -7
- Misses 2234 2241 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…elog Covers the end-to-end chain: a pending work order's Cancel button should disappear in a live session once its run gets claimed, via Query.state_for -> WorkOrders.update_state -> WorkOrderUpdated broadcast -> LiveView re-render. Unit tests cover the SQL mapping; this covers the whole chain. Also notes in the changelog that API consumers of /api/workorders and workflow channel subscribers will observe the :pending -> :running shift.
elias-ba
approved these changes
Apr 20, 2026
midigofrank
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is likely to be super contentious, but the reality is that once it's claimed, we CANNOT STOP IT or get it back.
It can no longer be "cancelled". From the perspective of Lightning it's running, and we can't stop it.
Closes #4635
Validation steps
(Roina, can you show me how to find that edge case?)
AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)